Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get measured data using active realizations #6188

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Get measured data using active realizations #6188

merged 2 commits into from
Sep 27, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 27, 2023

This bug caused misfit_preprocessor to fail on cases with failed realizations.

(cherry picked from commit 0b8b74a)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda
Get measured data using active realizations
1aa0069 
This bug caused misfit_preprocessor to fail on cases
with failed realizations.

(cherry picked from commit 0b8b74a)
@dafeda
Test that measured data work with failed reals
e3e6551 
This caused the misfit preprocessor to fail when run
on cases that have failed realizations.

(cherry picked from commit b756eba)
@dafeda dafeda self-assigned this Sep 27, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #6188 (e3e6551) into version-6.0 (33178ef) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@               Coverage Diff               @@
##           version-6.0    #6188      +/-   ##
===============================================
- Coverage        81.79%   81.79%   -0.01%     
===============================================
  Files              351      351              
  Lines            21843    21847       +4     
  Branches           758      758              
===============================================
+ Hits             17867    17870       +3     
  Misses            3724     3724              
- Partials           252      253       +1
Files Coverage Δ
src/ert/data/_measured_data.py 78.57% <83.33%> (-0.16%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dafeda dafeda merged commit 866a308 into equinor:version-6.0 Sep 27, 2023
40 checks passed
@dafeda dafeda deleted the cherry_pick_misfit branch September 27, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyvindeide oyvindeide oyvindeide approved these changes

Assignees

@dafeda dafeda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dafeda @codecov-commenter @oyvindeide